Skip to content

Only allow to set unique id from positioned #6343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2019
Merged

Only allow to set unique id from positioned #6343

merged 3 commits into from
Apr 23, 2019

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki
Only allow to set uniqueId from positioned
6eb78e8
@nicolasstucki
Add alternative possition tracking template
cadb4de 
When there is the need to recompile the Dotty library the assertion may fail.
@nicolasstucki nicolasstucki requested a review from biboudis April 18, 2019 16:21
biboudis
biboudis suggested changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested changes 🤣 💥

@biboudis biboudis merged commit 2a033aa into scala:master Apr 23, 2019
@biboudis biboudis deleted the only-allow-to-set-unique-id-from-positioned branch April 23, 2019 12:17
@ghost ghost removed the stat:needs review label Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biboudis biboudis biboudis approved these changes

Assignees

@biboudis biboudis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @biboudis